Fix govet issues.

database/database.go

@@ -36,13 +36,13 @@ func Init() {
 	logger.Info.Printf("Init database (file %s)", DatabaseFile)
 	d, err := sql.Open("sqlite3", DatabaseFile)
 	if err != nil {
-		logger.Error.Printf("Error on openning database", err)
+		logger.Error.Printf("Error on openning database : %v", err)
 	}
 	db = d
 
 	_, err = db.Exec(createDatabaseStmt)
 	if err != nil {
-		logger.Error.Printf("Failed to create table", err)
+		logger.Error.Printf("Failed to create table : %v", err)
 	}
 }
 
@@ -60,7 +60,7 @@ func (newLine *DatabaseLine) AddLine() bool {
 
 	stmt, err := db.Prepare(insertDatabaseStmt)
 	if err != nil {
-		logger.Error.Printf("Error on insert jid %s", newLine.Jid, err)
+		logger.Error.Printf("Error on insert jid %s : %v", newLine.Jid, err)
 		return false
 	}
 	defer stmt.Close()
@@ -70,7 +70,7 @@ func (newLine *DatabaseLine) AddLine() bool {
 	}
 	_, err = stmt.Exec(newLine.Jid, newLine.SteamLogin, newLine.SteamPwd, debug)
 	if err != nil {
-		logger.Error.Printf("Error on creating SQL statement", err)
+		logger.Error.Printf("Error on creating SQL statement : %v", err)
 		return false
 	}
 
@@ -81,7 +81,7 @@ func (newLine *DatabaseLine) UpdateLine() bool {
 	logger.Info.Printf("Update line %s", newLine.Jid)
 	stmt, err := db.Prepare(updateDatabaseStmt)
 	if err != nil {
-		logger.Error.Printf("Error on update ", err)
+		logger.Error.Printf("Error on update : %v", err)
 		return false
 	}
 	defer stmt.Close()
@@ -95,7 +95,7 @@ func (newLine *DatabaseLine) UpdateLine() bool {
 	}
 	_, err = stmt.Exec(newLine.SteamLogin, newLine.SteamPwd, debug, newLine.Jid)
 	if err != nil {
-		logger.Error.Printf("Error on updating SQL statement", err)
+		logger.Error.Printf("Error on updating SQL statement : %v", err)
 		return false
 	}
 
@@ -123,19 +123,19 @@ func RemoveLine(jid string) bool {
 	logger.Info.Printf("Remove line %s", jid)
 	stmt, err := db.Prepare(deleteDatabaseStmt)
 	if err != nil {
-		logger.Error.Printf("Error on delete jid %s", jid, err)
+		logger.Error.Printf("Error on delete jid %s : %v", jid, err)
 		return false
 	}
 	defer stmt.Close()
 	res, err := stmt.Exec(jid)
 	if err != nil {
-		logger.Error.Printf("Error on delete SQL statement", err)
+		logger.Error.Printf("Error on delete SQL statement : %v", err)
 		return false
 	}
 
 	affect, err := res.RowsAffected()
 	if err != nil {
-		logger.Error.Printf("Error on delete SQL statement", err)
+		logger.Error.Printf("Error on delete SQL statement : %v", err)
 		return false
 	}
 	if affect == 0 {
@@ -163,14 +163,14 @@ func getLine(jid string) *DatabaseLine {
 
 	stmt, err := db.Prepare(selectDatabaseStmt)
 	if err != nil {
-		logger.Error.Printf("Error on select line", err)
+		logger.Error.Printf("Error on select line : %v", err)
 		return nil
 	}
 	defer stmt.Close()
 	debug := 0
 	err = stmt.QueryRow(jid).Scan(&ret.Jid, &ret.SteamLogin, &ret.SteamPwd, &debug)
 	if err != nil {
-		logger.Error.Printf("Error on select scan", err)
+		logger.Error.Printf("Error on select scan : %v", err)
 		return nil
 	}
 	if debug == 1 {
@@ -188,7 +188,7 @@ func GetAllLines() []DatabaseLine {
 
 	rows, err := db.Query(selectAllDatabaseStmt)
 	if err != nil {
-		logger.Error.Printf("Error on select query", err)
+		logger.Error.Printf("Error on select query : %v", err)
 	}
 	defer rows.Close()
 	for rows.Next() {

gateway/steam.go

@@ -66,12 +66,12 @@ func (g *GatewayInfo) mainSteam() {
 			g.SendXmppMessage(XmppJidComponent, "", "Connected on Steam network")
 
 		case *steam.LoggedOffEvent:
-			logger.Error.Printf("[%s] LoggedOffEvent: ", g.XMPP_JID_Client, e)
+			logger.Error.Printf("[%s] LoggedOffEvent: %v", g.XMPP_JID_Client, e)
 			g.SendXmppMessage(XmppJidComponent, "", fmt.Sprintf("Disconnected of Steam network (%v)", e))
 			g.SteamConnecting = false
 
 		case steam.FatalErrorEvent:
-			logger.Error.Printf("[%s] FatalError: ", g.XMPP_JID_Client, e)
+			logger.Error.Printf("[%s] FatalError: %v", g.XMPP_JID_Client, e)
 			g.SendXmppMessage(XmppJidComponent, "", fmt.Sprintf("Steam Fatal Error : %v", e))
 			g.DisconnectAllSteamFriend()
 			g.SteamConnecting = false
@@ -83,11 +83,11 @@ func (g *GatewayInfo) mainSteam() {
 			g.SteamConnecting = false
 
 		case error:
-			logger.Error.Printf("[%s] ", g.XMPP_JID_Client, e)
+			logger.Error.Printf("[%s] error: %v", g.XMPP_JID_Client, e)
 			g.SendXmppMessage(XmppJidComponent, "", "Steam Error : "+e.Error())
 
 		case *steam.LogOnFailedEvent:
-			logger.Error.Printf("[%s] Login failed", g.XMPP_JID_Client, e)
+			logger.Error.Printf("[%s] Login failed: %v", g.XMPP_JID_Client, e)
 			g.SendXmppMessage(XmppJidComponent, "", fmt.Sprintf("Login failed : %v", e.Result))
 			g.SteamConnecting = false
 
@@ -226,7 +226,7 @@ func (g *GatewayInfo) SteamDisconnect() {
 
 func (g *GatewayInfo) DisconnectAllSteamFriend() {
 	logger.Debug.Printf("[%s] Disconnect all Steam friend", g.XMPP_JID_Client)
-	for sid, _ := range g.FriendSteamId {
+	for sid := range g.FriendSteamId {
 		g.SendXmppPresence(Status_offline, Type_unavailable, "", sid+"@"+XmppJidComponent, "", "")
 		delete(g.FriendSteamId, sid)
 	}

gateway/xmpp.go

@@ -230,7 +230,7 @@ func (g *GatewayInfo) addUserIntoRoster(jid, nick string) {
 
 func (g *GatewayInfo) removeAllUserFromRoster() {
 	// Friends
-	for steamId, _ := range g.SteamClient.Social.Friends.GetCopy() {
+	for steamId := range g.SteamClient.Social.Friends.GetCopy() {
 		iq := xmpp.Iq{To: g.XMPP_JID_Client, Type: xmpp.IQTypeSet, Id: NextIqId()}
 		query := &xmpp.RosterQuery{}
 		query.Items = append(query.Items, *&xmpp.RosterItem{JID: steamId.ToString() + "@" + XmppJidComponent, Subscription: xmpp.RosterSubscriptionRemove})

xmpp/commands.go

@@ -282,7 +282,7 @@ func execCommandAdHoc(iq *xmpp.Iq) {
 			}
 			if message != "" {
 				// Succeeded
-				for userJID, _ := range MapGatewayInfo {
+				for userJID := range MapGatewayInfo {
 					SendMessage(userJID, "", message)
 				}
 				note.Value = "Message sended to all registered users"